brute_force_prefiltered test warp boundary but with less input - #2579
Open
robertmaynard wants to merge 5 commits into
Open
robertmaynard wants to merge 5 commits into
robertmaynard wants to merge 5 commits into
Conversation
robertmaynard
added
improvement
tfeher
approved these changes
Sep 10, 2026
tfeher
left a comment
tfeher
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @robertmaynard!
robertmaynard
force-pushed
the
fea/improve_neighbors_brute_force_prefiltered_test_time
branch
from
September 12, 2026 00:03
b9bac9a to
1179554
Compare
The brute_force_prefiltered previous changes back to `205[0,1,2]` didn't fix the issue so increase the density arg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the longest running test items in brute_force_prefiltered.cu we can do a tweaks to improve runtime:
kSddmmMaxSelectivitythresholdThese combine together to remove 20 minutes from
NEIGHBORS_TEST.